From 8bb54944387c644f8e4cd7382816f9d78bc32a0f Mon Sep 17 00:00:00 2001 From: Aliaksei Chapyzhenka Date: Sat, 3 Oct 2020 19:59:16 -0700 Subject: [PATCH 1/3] Create CONTRIBUTING.md --- CONTRIBUTING.md | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 0000000..ca21601 --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,21 @@ +# Contributing + +When contributing to this repository, please first discuss the change you wish to make via +issue, email, or any other method with the owners of this repository before making a change. + +## Pull Request Process + +1) fork the project +2) if you're fixing a bug also create an issue if one doesn't exist yet +3) if it's a new feature explain why do you think it's necessary +4) do not include changes that are not related to the issue at hand +5) follow the same coding style with regards to spaces, semicolons, variable naming etc +6) add tests +4) make sure you install all dependencies by running `npm i` +5) make sure you tested your code by running `npm test` +6) when you think the code is ready for review a pull request should be created + +## Code of Conduct + +This project adheres to No Code of Conduct. We are all adults. We accept anyone's contributions. Nothing else matters. +For more information please visit the [No Code of Conduct](https://github.com/domgetter/NCoC) homepage. From 42de6aa745f7277ed796320f6d90294dc51e427e Mon Sep 17 00:00:00 2001 From: Aliaksei Chapyzhenka Date: Sat, 3 Oct 2020 21:57:45 -0700 Subject: [PATCH 2/3] added twitter --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ca21601..d9a5c46 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,7 +1,7 @@ # Contributing When contributing to this repository, please first discuss the change you wish to make via -issue, email, or any other method with the owners of this repository before making a change. +issue, email, twitter, or any other method with the owners of this repository before making a change. ## Pull Request Process From b13766e5838519643973dbad0b8581965f2cb260 Mon Sep 17 00:00:00 2001 From: Aliaksei Chapyzhenka Date: Sun, 4 Oct 2020 13:12:50 -0700 Subject: [PATCH 3/3] Update CONTRIBUTING.md --- CONTRIBUTING.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d9a5c46..bd9ca5f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -11,9 +11,10 @@ issue, email, twitter, or any other method with the owners of this repository be 4) do not include changes that are not related to the issue at hand 5) follow the same coding style with regards to spaces, semicolons, variable naming etc 6) add tests -4) make sure you install all dependencies by running `npm i` -5) make sure you tested your code by running `npm test` -6) when you think the code is ready for review a pull request should be created +7) make sure you install all dependencies by running `npm i` +8) make sure you tested your code by running `npm test` +9) if changing C/C++ code, you must verify that NAPI and WASM both pass tests +10) when you think the code is ready for review a pull request should be created ## Code of Conduct