Update CONTRIBUTING.md

This commit is contained in:
Aliaksei Chapyzhenka 2020-10-04 13:12:50 -07:00 committed by GitHub
parent 42de6aa745
commit b13766e583
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -11,9 +11,10 @@ issue, email, twitter, or any other method with the owners of this repository be
4) do not include changes that are not related to the issue at hand 4) do not include changes that are not related to the issue at hand
5) follow the same coding style with regards to spaces, semicolons, variable naming etc 5) follow the same coding style with regards to spaces, semicolons, variable naming etc
6) add tests 6) add tests
4) make sure you install all dependencies by running `npm i` 7) make sure you install all dependencies by running `npm i`
5) make sure you tested your code by running `npm test` 8) make sure you tested your code by running `npm test`
6) when you think the code is ready for review a pull request should be created 9) if changing C/C++ code, you must verify that NAPI and WASM both pass tests
10) when you think the code is ready for review a pull request should be created
## Code of Conduct ## Code of Conduct